diff options
| author |   Nikita Danilov <nikita.danilov@aquantia.com> | 2019-02-27 12:10:03 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-01 16:45:15 -0800 |
| commit | ff83dbf21e79d03f3788943a5bce12c39a06a3ab (patch) | |
| tree | c1a149241e804d50d31d82adcb8f8f1c68468d6a /drivers/net/ethernet/aquantia | |
| parent | Merge branch 'nfp-control-processor-DMA-support-and-RJ45' (diff) | |
| download | linux-dev-ff83dbf21e79d03f3788943a5bce12c39a06a3ab.tar.xz linux-dev-ff83dbf21e79d03f3788943a5bce12c39a06a3ab.zip | |
net: aquantia: fixed memcpy size
Not careful array dereference caused analysis tools
to think there could be memory overflow.
There was actually no corruption because the array is
two dimensional.
drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c: 140
aq_ethtool_get_strings() error:
memcpy() '*aq_ethtool_stat_names' too small (32 vs 704)
Signed-off-by: Nikita Danilov <nikita.danilov@aquantia.com>
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/aquantia')
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c index 38e87eed76b9..a718d7a1f76c 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c @@ -138,7 +138,7 @@ static void aq_ethtool_get_strings(struct net_device *ndev, u8 *p = data; if (stringset == ETH_SS_STATS) { - memcpy(p, *aq_ethtool_stat_names, + memcpy(p, aq_ethtool_stat_names, sizeof(aq_ethtool_stat_names)); p = p + sizeof(aq_ethtool_stat_names); for (i = 0; i < cfg->vecs; i++) { |