diff options
| author |   Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-08-23 16:56:47 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-08-24 17:59:44 -0700 |
| commit | e2d79cd8875fa8c3cc7defa98a8cc99a1ed0c62f (patch) | |
| tree | 94ebce0a519b63dceaf3ece3b01b57121532c9e2 /drivers/net/ethernet/arc | |
| parent | NFC: st95hf: Fix memleak in st95hf_in_send_cmd (diff) | |
| download | linux-dev-e2d79cd8875fa8c3cc7defa98a8cc99a1ed0c62f.tar.xz linux-dev-e2d79cd8875fa8c3cc7defa98a8cc99a1ed0c62f.zip | |
net: arc_emac: Fix memleak in arc_mdio_probe
When devm_gpiod_get_optional() fails, bus should be
freed just like when of_mdiobus_register() fails.
Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/arc')
| -rw-r--r-- | drivers/net/ethernet/arc/emac_mdio.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/arc/emac_mdio.c b/drivers/net/ethernet/arc/emac_mdio.c index 0187dbf3b87d..54cdafdd067d 100644 --- a/drivers/net/ethernet/arc/emac_mdio.c +++ b/drivers/net/ethernet/arc/emac_mdio.c @@ -153,6 +153,7 @@ int arc_mdio_probe(struct arc_emac_priv *priv) if (IS_ERR(data->reset_gpio)) { error = PTR_ERR(data->reset_gpio); dev_err(priv->dev, "Failed to request gpio: %d\n", error); + mdiobus_free(bus); return error; } |