diff options
| author |   Jakub Kicinski <kuba@kernel.org> | 2021-10-04 09:05:21 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-10-05 13:16:48 +0100 |
| commit | a05e4c0af490ca7c22fc77120aafebebdeaaf537 (patch) | |
| tree | 093f856055c374789e43c55e5b4f8842e1f513fb /drivers/net/ethernet/atheros/alx | |
| parent | Merge branch 'mlx4-const-dev_addr' (diff) | |
| download | linux-dev-a05e4c0af490ca7c22fc77120aafebebdeaaf537.tar.xz linux-dev-a05e4c0af490ca7c22fc77120aafebebdeaaf537.zip | |
ethernet: use eth_hw_addr_set() for dev->addr_len cases
Convert all Ethernet drivers from memcpy(... dev->addr_len)
to eth_hw_addr_set():
@@
expression dev, np;
@@
- memcpy(dev->dev_addr, np, dev->addr_len)
+ eth_hw_addr_set(dev, np)
In theory addr_len may not be ETH_ALEN, but we don't expect
non-Ethernet devices to live under this directory, and only
the following cases of setting addr_len exist:
- cxgb4 for mgmt device,
and the drivers which set it to ETH_ALEN: s2io, mlx4, vxge.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/atheros/alx')
| -rw-r--r-- | drivers/net/ethernet/atheros/alx/main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index cf5903ac792b..4ad3fc72e74e 100644 --- a/drivers/net/ethernet/atheros/alx/main.c +++ b/drivers/net/ethernet/atheros/alx/main.c @@ -607,7 +607,7 @@ static int alx_set_mac_address(struct net_device *netdev, void *data) if (netdev->addr_assign_type & NET_ADDR_RANDOM) netdev->addr_assign_type ^= NET_ADDR_RANDOM; - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); + eth_hw_addr_set(netdev, addr->sa_data); memcpy(hw->mac_addr, addr->sa_data, netdev->addr_len); alx_set_macaddr(hw, hw->mac_addr); |