diff options
| author |   Rafał Miłecki <rafal@milecki.pl> | 2021-02-11 13:12:36 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-02-11 15:04:17 -0800 |
| commit | 7b778ae4eb9cd6e1518e4e47902a104b13ae8929 (patch) | |
| tree | 678651eeeb1434ac4c969037bc6404d3fe12b877 /drivers/net/ethernet/broadcom/bcm4908_enet.c | |
| parent | net: broadcom: bcm4908_enet: drop unneeded memset() (diff) | |
| download | linux-dev-7b778ae4eb9cd6e1518e4e47902a104b13ae8929.tar.xz linux-dev-7b778ae4eb9cd6e1518e4e47902a104b13ae8929.zip | |
net: broadcom: bcm4908_enet: drop "inline" from C functions
It seems preferred to let compiler optimize code if applicable.
While at it drop unused enet_umac_maskset().
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bcm4908_enet.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bcm4908_enet.c | 19 |
1 files changed, 7 insertions, 12 deletions
diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c index f4e31646d50f..7d619aa9410a 100644 --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c @@ -75,17 +75,17 @@ struct bcm4908_enet { * R/W ops */ -static inline u32 enet_read(struct bcm4908_enet *enet, u16 offset) +static u32 enet_read(struct bcm4908_enet *enet, u16 offset) { return readl(enet->base + offset); } -static inline void enet_write(struct bcm4908_enet *enet, u16 offset, u32 value) +static void enet_write(struct bcm4908_enet *enet, u16 offset, u32 value) { writel(value, enet->base + offset); } -static inline void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set) +static void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set) { u32 val; @@ -96,27 +96,22 @@ static inline void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, enet_write(enet, offset, val); } -static inline void enet_set(struct bcm4908_enet *enet, u16 offset, u32 set) +static void enet_set(struct bcm4908_enet *enet, u16 offset, u32 set) { enet_maskset(enet, offset, set, set); } -static inline u32 enet_umac_read(struct bcm4908_enet *enet, u16 offset) +static u32 enet_umac_read(struct bcm4908_enet *enet, u16 offset) { return enet_read(enet, ENET_UNIMAC + offset); } -static inline void enet_umac_write(struct bcm4908_enet *enet, u16 offset, u32 value) +static void enet_umac_write(struct bcm4908_enet *enet, u16 offset, u32 value) { enet_write(enet, ENET_UNIMAC + offset, value); } -static inline void enet_umac_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set) -{ - enet_maskset(enet, ENET_UNIMAC + offset, mask, set); -} - -static inline void enet_umac_set(struct bcm4908_enet *enet, u16 offset, u32 set) +static void enet_umac_set(struct bcm4908_enet *enet, u16 offset, u32 set) { enet_set(enet, ENET_UNIMAC + offset, set); } |