diff options
| author |   Rafał Miłecki <rafal@milecki.pl> | 2016-08-17 15:37:14 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-08-18 23:23:41 -0700 |
| commit | b9f63ae7ba2de2ba19137c5757c0607ce40f3ed5 (patch) | |
| tree | 32032a4538efc57fce4bd912d07dfafe6de9a805 /drivers/net/ethernet/broadcom/bgmac-bcma.c | |
| parent | tcp: fix use after free in tcp_xmit_retransmit_queue() (diff) | |
| download | linux-dev-b9f63ae7ba2de2ba19137c5757c0607ce40f3ed5.tar.xz linux-dev-b9f63ae7ba2de2ba19137c5757c0607ce40f3ed5.zip | |
net: bgmac: fix reversed check for MII registration error
It was failing on successful registration returning meaningless errors.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file")
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bgmac-bcma.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bgmac-bcma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c index 9a9745c4047c..625235db644f 100644 --- a/drivers/net/ethernet/broadcom/bgmac-bcma.c +++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c @@ -159,7 +159,7 @@ static int bgmac_probe(struct bcma_device *core) if (!bgmac_is_bcm4707_family(core)) { mii_bus = bcma_mdio_mii_register(core, bgmac->phyaddr); - if (!IS_ERR(mii_bus)) { + if (IS_ERR(mii_bus)) { err = PTR_ERR(mii_bus); goto err; } |