diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-06-13 22:53:50 +0200 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-06-14 19:16:36 -0700 |
| commit | d7dd6eccfbc95ac47a12396f84e7e1b361db654b (patch) | |
| tree | 44aa7475f0630d70e86ad7324e5040c6d960668d /drivers/net/ethernet/broadcom/bgmac-bcma.c | |
| parent | mlxsw: spectrum_cnt: Reorder counter pools (diff) | |
| download | linux-dev-d7dd6eccfbc95ac47a12396f84e7e1b361db654b.tar.xz linux-dev-d7dd6eccfbc95ac47a12396f84e7e1b361db654b.zip | |
net: bgmac: Fix an erroneous kfree() in bgmac_remove()
'bgmac' is part of a managed resource allocated with bgmac_alloc(). It
should not be freed explicitly.
Remove the erroneous kfree() from the .remove() function.
Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/a026153108dd21239036a032b95c25b5cece253b.1655153616.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bgmac-bcma.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bgmac-bcma.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c index e6f48786949c..02bd3cf9a260 100644 --- a/drivers/net/ethernet/broadcom/bgmac-bcma.c +++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c @@ -332,7 +332,6 @@ static void bgmac_remove(struct bcma_device *core) bcma_mdio_mii_unregister(bgmac->mii_bus); bgmac_enet_remove(bgmac); bcma_set_drvdata(core, NULL); - kfree(bgmac); } static struct bcma_driver bgmac_bcma_driver = { |