diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2016-06-23 14:25:33 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-06-28 04:22:17 -0400 |
| commit | 3894396e64994f31c3ef5c7e6f63dded0593e567 (patch) | |
| tree | a35d34b93e06d0227b7b69298c6b2166c3185b45 /drivers/net/ethernet/broadcom/bgmac.c | |
| parent | net: bgmac: Start transmit queue in bgmac_open (diff) | |
| download | linux-dev-3894396e64994f31c3ef5c7e6f63dded0593e567.tar.xz linux-dev-3894396e64994f31c3ef5c7e6f63dded0593e567.zip | |
net: bgmac: Remove superflous netif_carrier_on()
bgmac_open() calls phy_start() to initialize the PHY state machine,
which will set the interface's carrier state accordingly, no need to
force that as this could be conflicting with the PHY state determined by
PHYLIB.
Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bgmac.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bgmac.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index 85cd07f72ffb..a6333d38ecc0 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -1313,8 +1313,6 @@ static int bgmac_open(struct net_device *net_dev) phy_start(bgmac->phy_dev); - netif_carrier_on(net_dev); - netif_start_queue(net_dev); return 0; |