diff options
| author |   Vasundhara Volam <vasundhara-v.volam@broadcom.com> | 2019-12-10 02:49:10 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-12-10 17:37:14 -0800 |
| commit | 8280b38e01f71e0f89389ccad3fa43b79e57c604 (patch) | |
| tree | aa26ebc9a8e48f35fc7c3af5008cc19b6c2907fc /drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | |
| parent | bnxt_en: Return error if FW returns more data than dump length (diff) | |
| download | linux-dev-8280b38e01f71e0f89389ccad3fa43b79e57c604.tar.xz linux-dev-8280b38e01f71e0f89389ccad3fa43b79e57c604.zip | |
bnxt_en: Fix bp->fw_health allocation and free logic.
bp->fw_health needs to be allocated for either the firmware initiated
reset feature or the driver initiated error recovery feature. The
current code is not allocating bp->fw_health for all the necessary cases.
This patch corrects the logic to allocate bp->fw_health correctly when
needed. If allocation fails, we clear the feature flags.
We also add the the missing kfree(bp->fw_health) when the driver is
unloaded. If we get an async reset message from the firmware, we also
need to make sure that we have a valid bp->fw_health before proceeding.
Fixes: 07f83d72d238 ("bnxt_en: Discover firmware error recovery capabilities.")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c')
0 files changed, 0 insertions, 0 deletions