diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2019-10-11 12:53:49 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-15 10:53:19 -0700 |
| commit | 92696286f3bb37ba50e4bd8d1beb24afb759a799 (patch) | |
| tree | ef74520060ee65703da16eb016e85556d53650de /drivers/net/ethernet/broadcom/genet/bcmmii.c | |
| parent | blackhole_netdev: fix syzkaller reported issue (diff) | |
| download | linux-dev-92696286f3bb37ba50e4bd8d1beb24afb759a799.tar.xz linux-dev-92696286f3bb37ba50e4bd8d1beb24afb759a799.zip | |
net: bcmgenet: Set phydev->dev_flags only for internal PHYs
phydev->dev_flags is entirely dependent on the PHY device driver which
is going to be used, setting the internal GENET PHY revision in those
bits only makes sense when drivers/net/phy/bcm7xxx.c is the PHY driver
being used.
Fixes: 487320c54143 ("net: bcmgenet: communicate integrated PHY revision to PHY driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/genet/bcmmii.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 970e478a9017..94d1dd5d56bf 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -273,11 +273,12 @@ int bcmgenet_mii_probe(struct net_device *dev) struct bcmgenet_priv *priv = netdev_priv(dev); struct device_node *dn = priv->pdev->dev.of_node; struct phy_device *phydev; - u32 phy_flags; + u32 phy_flags = 0; int ret; /* Communicate the integrated PHY revision */ - phy_flags = priv->gphy_rev; + if (priv->internal_phy) + phy_flags = priv->gphy_rev; /* Initialize link state variables that bcmgenet_mii_setup() uses */ priv->old_link = -1; |