diff options
| author |   Andrew Lunn <andrew@lunn.ch> | 2018-09-12 01:53:12 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-12 20:24:21 -0700 |
| commit | 00eb2243b933a496958f4ce1bcf59840fea8be16 (patch) | |
| tree | df4d384c0ecfd12f839fcf48a77735f1e0ec257b /drivers/net/ethernet/broadcom/genet | |
| parent | net: ethernet: Use phy_set_max_speed() to limit advertised speed (diff) | |
| download | linux-dev-00eb2243b933a496958f4ce1bcf59840fea8be16.tar.xz linux-dev-00eb2243b933a496958f4ce1bcf59840fea8be16.zip | |
net: bcmgenet: Fix speed selection for reverse MII
The phy supported speed is being used to determine if the MAC should
be configured to 100 or 1G. The masking logic is broken. Instead, look
at 1G supported speeds to enable 1G MAC support.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/genet')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index b11d58f1bf45..b756fc79424e 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -226,11 +226,10 @@ int bcmgenet_mii_config(struct net_device *dev, bool init) * capabilities, use that knowledge to also configure the * Reverse MII interface correctly. */ - if ((dev->phydev->supported & PHY_BASIC_FEATURES) == - PHY_BASIC_FEATURES) - port_ctrl = PORT_MODE_EXT_RVMII_25; - else + if (dev->phydev->supported & PHY_1000BT_FEATURES) port_ctrl = PORT_MODE_EXT_RVMII_50; + else + port_ctrl = PORT_MODE_EXT_RVMII_25; bcmgenet_sys_writel(priv, port_ctrl, SYS_PORT_CTRL); break; |