diff options
| author |   Zhang Changzhong <zhangchangzhong@huawei.com> | 2020-07-20 15:18:43 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-07-20 16:57:53 -0700 |
| commit | 24a63fe6d45d6527db5ab87bcd1da6921f10e89e (patch) | |
| tree | 5ce6929e60b2898fc767040f0c87e68e84188016 /drivers/net/ethernet/broadcom/genet | |
| parent | bonding: check error value of register_netdevice() immediately (diff) | |
| download | linux-dev-24a63fe6d45d6527db5ab87bcd1da6921f10e89e.tar.xz linux-dev-24a63fe6d45d6527db5ab87bcd1da6921f10e89e.zip | |
net: bcmgenet: fix error returns in bcmgenet_probe()
The driver forgets to call clk_disable_unprepare() in error path after
a success calling for clk_prepare_enable().
Fix to goto err_clk_disable if clk_prepare_enable() is successful.
Fixes: 99d55638d4b0 ("net: bcmgenet: enable NETIF_F_HIGHDMA flag")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/genet')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 368e05b16ae9..903811e843d2 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3988,7 +3988,7 @@ static int bcmgenet_probe(struct platform_device *pdev) if (err) err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (err) - goto err; + goto err_clk_disable; /* Mii wait queue */ init_waitqueue_head(&priv->wq); |