diff options
| author |   Michael Chan <michael.chan@broadcom.com> | 2016-11-11 00:11:43 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-11-13 12:37:31 -0500 |
| commit | 73b9bad63ae3c902ce64221d10a0d371d059748d (patch) | |
| tree | 0b0517adc1561c013fed7cc059cb4d2796dd78a6 /drivers/net/ethernet/broadcom | |
| parent | bnxt_en: Fix ring arithmetic in bnxt_setup_tc(). (diff) | |
| download | linux-dev-73b9bad63ae3c902ce64221d10a0d371d059748d.tar.xz linux-dev-73b9bad63ae3c902ce64221d10a0d371d059748d.zip | |
bnxt_en: Fix VF virtual link state.
If the physical link is down and the VF virtual link is set to "enable",
the current code does not always work. If the link is down but the
cable is attached, the firmware returns LINK_SIGNAL instead of
NO_LINK. The current code is treating LINK_SIGNAL as link up.
The fix is to treat link as down when the link_status != LINK.
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c index ec6cd18842c3..60e2af8678bd 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c @@ -774,8 +774,8 @@ static int bnxt_vf_set_link(struct bnxt *bp, struct bnxt_vf_info *vf) if (vf->flags & BNXT_VF_LINK_UP) { /* if physical link is down, force link up on VF */ - if (phy_qcfg_resp.link == - PORT_PHY_QCFG_RESP_LINK_NO_LINK) { + if (phy_qcfg_resp.link != + PORT_PHY_QCFG_RESP_LINK_LINK) { phy_qcfg_resp.link = PORT_PHY_QCFG_RESP_LINK_LINK; phy_qcfg_resp.link_speed = cpu_to_le16( |