diff options
| author |   Ivan Vecera <ivecera@redhat.com> | 2014-07-29 16:29:30 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-07-30 19:09:34 -0700 |
| commit | c36c9d50cc6af5c5bfcc195f21b73f55520c15f9 (patch) | |
| tree | 604e1af7914d0653510f4d2a69c28b152ec4c792 /drivers/net/ethernet/brocade | |
| parent | tcp: Fix integer-overflow in TCP vegas (diff) | |
| download | linux-dev-c36c9d50cc6af5c5bfcc195f21b73f55520c15f9.tar.xz linux-dev-c36c9d50cc6af5c5bfcc195f21b73f55520c15f9.zip | |
bna: fix performance regression
The recent commit "e29aa33 bna: Enable Multi Buffer RX" is causing
a performance regression. It does not properly update 'cmpl' pointer
at the end of the loop in NAPI handler bnad_cq_process(). The result is
only one packet / per NAPI-schedule is processed.
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/brocade')
| -rw-r--r-- | drivers/net/ethernet/brocade/bna/bnad.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index 3a77f9ead004..556aab75f490 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c @@ -600,9 +600,9 @@ bnad_cq_process(struct bnad *bnad, struct bna_ccb *ccb, int budget) prefetch(bnad->netdev); cq = ccb->sw_q; - cmpl = &cq[ccb->producer_index]; while (packets < budget) { + cmpl = &cq[ccb->producer_index]; if (!cmpl->valid) break; /* The 'valid' field is set by the adapter, only after writing |