diff options
| author |   Charles Keepax <ckeepax@opensource.wolfsonmicro.com> | 2016-03-28 13:47:42 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-03-28 11:39:16 -0400 |
| commit | 0e3e7999703e7df93a9deee8ba89b604c5fd662d (patch) | |
| tree | 654f202dc57e4b8a4af2e7016bf7de5781666bea /drivers/net/ethernet/cadence | |
| parent | net: hns: set-coalesce-usecs returns errno by dsaf.ko (diff) | |
| download | linux-dev-0e3e7999703e7df93a9deee8ba89b604c5fd662d.tar.xz linux-dev-0e3e7999703e7df93a9deee8ba89b604c5fd662d.zip | |
net: macb: Only call GPIO functions if there is a valid GPIO
GPIOlib will print warning messages if we call GPIO functions without a
valid GPIO. Change the code to avoid doing so.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/cadence')
| -rw-r--r-- | drivers/net/ethernet/cadence/macb.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 6c3dc27cb100..48a7d7dee846 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -2996,9 +2996,10 @@ static int macb_probe(struct platform_device *pdev) phy_node = of_get_next_available_child(np, NULL); if (phy_node) { int gpio = of_get_named_gpio(phy_node, "reset-gpios", 0); - if (gpio_is_valid(gpio)) + if (gpio_is_valid(gpio)) { bp->reset_gpio = gpio_to_desc(gpio); - gpiod_direction_output(bp->reset_gpio, 1); + gpiod_direction_output(bp->reset_gpio, 1); + } } of_node_put(phy_node); @@ -3068,7 +3069,8 @@ static int macb_remove(struct platform_device *pdev) mdiobus_free(bp->mii_bus); /* Shutdown the PHY if there is a GPIO reset */ - gpiod_set_value(bp->reset_gpio, 0); + if (bp->reset_gpio) + gpiod_set_value(bp->reset_gpio, 0); unregister_netdev(dev); clk_disable_unprepare(bp->tx_clk); |