diff options
| author |   Soren Brinkmann <soren.brinkmann@xilinx.com> | 2013-12-10 20:57:57 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-12-11 00:19:17 -0500 |
| commit | 9319e47c18c41f2748c4140b0ac32097a56f36c1 (patch) | |
| tree | ccad60e27e3a1ecdd84785f4f26d201fef56fdaf /drivers/net/ethernet/cadence | |
| parent | Merge branch 'tipc' (diff) | |
| download | linux-dev-9319e47c18c41f2748c4140b0ac32097a56f36c1.tar.xz linux-dev-9319e47c18c41f2748c4140b0ac32097a56f36c1.zip | |
net: macb: Fix build warning
When adjusting the link speed, the target frequency is determined by a
'swith (LINK_SPEED)' statement, that assigns the target rate only for
valid and expected LINK_SPEED values. This incomplete switch statement
leads to the following build warning:
drivers/net/ethernet/cadence/macb.c: In function 'macb_handle_link_change':
>> drivers/net/ethernet/cadence/macb.c:241:14: warning: 'rate' may be used uninitialized in this function [-Wmaybe-uninitialized]
netdev_warn(dev, "unable to generate target frequency: %ld Hz\n",
^
drivers/net/ethernet/cadence/macb.c:215:13: note: 'rate' was declared here
long ferr, rate, rate_rounded;
Fixing this by bailing out of that function in the switch's default case
before the rate variable is used.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/cadence')
| -rw-r--r-- | drivers/net/ethernet/cadence/macb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 419529a9309d..3190d38e16fb 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -225,7 +225,7 @@ static void macb_set_tx_clk(struct clk *clk, int speed, struct net_device *dev) rate = 125000000; break; default: - break; + return; } rate_rounded = clk_round_rate(clk, rate); |