diff options
| author |   Cai Huoqing <caihuoqing@baidu.com> | 2021-09-15 22:58:42 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-09-16 13:35:35 +0100 |
| commit | 52583c8d8b12f232bd1128de9f5895bcdad7d7a3 (patch) | |
| tree | 011c1350e58207a1bf5675e226ab3af89b36134d /drivers/net/ethernet/cavium/thunder/thunder_bgx.c | |
| parent | net: hinic: Make use of the helper function dev_err_probe() (diff) | |
| download | linux-dev-52583c8d8b12f232bd1128de9f5895bcdad7d7a3.tar.xz linux-dev-52583c8d8b12f232bd1128de9f5895bcdad7d7a3.zip | |
net: thunderx: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/cavium/thunder/thunder_bgx.c')
| -rw-r--r-- | drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index c36fed9c3d73..db66d4beb28a 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1597,9 +1597,8 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err = pcim_enable_device(pdev); if (err) { - dev_err(dev, "Failed to enable PCI device\n"); pci_set_drvdata(pdev, NULL); - return err; + return dev_err_probe(dev, err, "Failed to enable PCI device\n"); } err = pci_request_regions(pdev, DRV_NAME); |