diff options
| author |   Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> | 2021-06-11 12:17:46 +0530 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-11 11:15:00 -0700 |
| commit | f046bd0ae15d8a0bbe57d4647da182420f720c3d (patch) | |
| tree | bb061e3c1ec6ed2276ac5d2e377bbca39e89b6b2 /drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | |
| parent | cxgb4: fix endianness when flashing boot image (diff) | |
| download | linux-dev-f046bd0ae15d8a0bbe57d4647da182420f720c3d.tar.xz linux-dev-f046bd0ae15d8a0bbe57d4647da182420f720c3d.zip | |
cxgb4: fix sleep in atomic when flashing PHY firmware
Before writing new PHY firmware to on-chip memory, driver queries
firmware for current running PHY firmware version, which can result
in sleep waiting for reply. So, move spinlock closer to the actual
on-chip memory write operation, instead of taking it at the callers.
Fixes: 5fff701c838e ("cxgb4: always sync access when flashing PHY firmware")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c')
| -rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 1f601de02e70..762113a04dde 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -4424,10 +4424,8 @@ static int adap_init0_phy(struct adapter *adap) /* Load PHY Firmware onto adapter. */ - spin_lock_bh(&adap->win0_lock); ret = t4_load_phy_fw(adap, MEMWIN_NIC, phy_info->phy_fw_version, (u8 *)phyf->data, phyf->size); - spin_unlock_bh(&adap->win0_lock); if (ret < 0) dev_err(adap->pdev_dev, "PHY Firmware transfer error %d\n", -ret); |