diff options
| author |   Chuhong Yuan <hslester96@gmail.com> | 2019-11-14 23:43:24 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-11-15 12:42:09 -0800 |
| commit | 3df70afe8d33f4977d0e0891bdcfb639320b5257 (patch) | |
| tree | a006bed1656b8f7b9c30c7c52640b12e5c4e4097 /drivers/net/ethernet/cirrus/ep93xx_eth.c | |
| parent | ax88172a: fix information leak on short answers (diff) | |
| download | linux-dev-3df70afe8d33f4977d0e0891bdcfb639320b5257.tar.xz linux-dev-3df70afe8d33f4977d0e0891bdcfb639320b5257.zip | |
net: ep93xx_eth: fix mismatch of request_mem_region in remove
The driver calls release_resource in remove to match request_mem_region
in probe, which is incorrect.
Fix it by using the right one, release_mem_region.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/cirrus/ep93xx_eth.c')
| -rw-r--r-- | drivers/net/ethernet/cirrus/ep93xx_eth.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c index f1a0c4dceda0..f37c9a08c4cf 100644 --- a/drivers/net/ethernet/cirrus/ep93xx_eth.c +++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c @@ -763,6 +763,7 @@ static int ep93xx_eth_remove(struct platform_device *pdev) { struct net_device *dev; struct ep93xx_priv *ep; + struct resource *mem; dev = platform_get_drvdata(pdev); if (dev == NULL) @@ -778,8 +779,8 @@ static int ep93xx_eth_remove(struct platform_device *pdev) iounmap(ep->base_addr); if (ep->res != NULL) { - release_resource(ep->res); - kfree(ep->res); + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); + release_mem_region(mem->start, resource_size(mem)); } free_netdev(dev); |