diff options
| author |   Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2021-03-09 09:42:12 +0100 |
|---|---|---|
| committer |   Thomas Gleixner <tglx@linutronix.de> | 2021-03-17 16:34:00 +0100 |
| commit | 25cf87df1a3a85959bf1bf27df0eb2e6e04b2161 (patch) | |
| tree | bc45329cae35ba0b8adb627b3c0ced7a2ee786ce /drivers/net/ethernet/dlink | |
| parent | net: jme: Replace link-change tasklet with work (diff) | |
| download | linux-dev-25cf87df1a3a85959bf1bf27df0eb2e6e04b2161.tar.xz linux-dev-25cf87df1a3a85959bf1bf27df0eb2e6e04b2161.zip | |
net: sundance: Use tasklet_disable_in_atomic().
tasklet_disable() is used in the timer callback. This might be distangled,
but without access to the hardware that's a bit risky.
Replace it with tasklet_disable_in_atomic() so tasklet_disable() can be
changed to a sleep wait once all remaining atomic users are converted.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210309084242.209110861@linutronix.de
Diffstat (limited to 'drivers/net/ethernet/dlink')
| -rw-r--r-- | drivers/net/ethernet/dlink/sundance.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/dlink/sundance.c b/drivers/net/ethernet/dlink/sundance.c index e3a8858915b3..df0eab479d51 100644 --- a/drivers/net/ethernet/dlink/sundance.c +++ b/drivers/net/ethernet/dlink/sundance.c @@ -963,7 +963,7 @@ static void tx_timeout(struct net_device *dev, unsigned int txqueue) unsigned long flag; netif_stop_queue(dev); - tasklet_disable(&np->tx_tasklet); + tasklet_disable_in_atomic(&np->tx_tasklet); iowrite16(0, ioaddr + IntrEnable); printk(KERN_WARNING "%s: Transmit timed out, TxStatus %2.2x " "TxFrameId %2.2x," |