diff options
| author |   Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com> | 2012-04-25 01:46:39 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2012-04-26 05:03:31 -0400 |
| commit | af311fe31015e2b27bd65e22fc103230fb3a78b7 (patch) | |
| tree | 421ab810a20c2750117db102e8fa1661a44c54ce /drivers/net/ethernet/emulex | |
| parent | be2net: Fix ethtool self test for Lancer (diff) | |
| download | linux-dev-af311fe31015e2b27bd65e22fc103230fb3a78b7.tar.xz linux-dev-af311fe31015e2b27bd65e22fc103230fb3a78b7.zip | |
be2net: Fix traffic stall INTx mode
EQ is getting armed wrongly in INTx mode as INTx interrupt is taking
some time to deassert. This can cause another interrupt while NAPI is
scheduled and scheduling a NAPI in interrupt does not take effect.
This causes interrupt to be missed and traffic stalls. Fixing this by
preventing wrong arming of EQ.
Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/emulex')
| -rw-r--r-- | drivers/net/ethernet/emulex/benet/be_main.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index a9a11d426f08..9d42fab6d446 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -1571,7 +1571,9 @@ static int event_handle(struct be_eq_obj *eqo) if (!num) rearm = true; - be_eq_notify(eqo->adapter, eqo->q.id, rearm, true, num); + if (num || msix_enabled(eqo->adapter)) + be_eq_notify(eqo->adapter, eqo->q.id, rearm, true, num); + if (num) napi_schedule(&eqo->napi); |