diff options
| author |   Robert-Ionut Alexa <robert-ionut.alexa@nxp.com> | 2022-02-09 17:57:43 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-02-10 15:21:53 +0000 |
| commit | 9ccc6e0c8959a019bb40f6b18704b142c04b19a8 (patch) | |
| tree | f895aef32cf6026ae93d6341153bcff0a946ba81 /drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | |
| parent | skbuff: cleanup double word in comment (diff) | |
| download | linux-dev-9ccc6e0c8959a019bb40f6b18704b142c04b19a8.tar.xz linux-dev-9ccc6e0c8959a019bb40f6b18704b142c04b19a8.zip | |
dpaa2-eth: unregister the netdev before disconnecting from the PHY
The netdev should be unregistered before we are disconnecting from the
MAC/PHY so that the dev_close callback is called and the PHY and the
phylink workqueues are actually stopped before we are disconnecting and
destroying the phylink instance.
Fixes: 719479230893 ("dpaa2-eth: add MAC/PHY support through phylink")
Signed-off-by: Robert-Ionut Alexa <robert-ionut.alexa@nxp.com>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index e985ae008a97..dd9385d15f6b 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -4523,12 +4523,12 @@ static int dpaa2_eth_remove(struct fsl_mc_device *ls_dev) #ifdef CONFIG_DEBUG_FS dpaa2_dbg_remove(priv); #endif + + unregister_netdev(net_dev); rtnl_lock(); dpaa2_eth_disconnect_mac(priv); rtnl_unlock(); - unregister_netdev(net_dev); - dpaa2_eth_dl_port_del(priv); dpaa2_eth_dl_traps_unregister(priv); dpaa2_eth_dl_free(priv); |