diff options
| author |   Andrew Lunn <andrew@lunn.ch> | 2017-07-30 22:11:06 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-07-30 19:25:22 -0700 |
| commit | 9558df3a8251f1c636eaf3d2222b6da2eb5d1086 (patch) | |
| tree | 5a0e511c566d8c23cfc9b93a1e03b43fa6165de3 /drivers/net/ethernet/freescale/fec_main.c | |
| parent | Merge branch 'dsa-lan9303-Fix-MDIO-issues' (diff) | |
| download | linux-dev-9558df3a8251f1c636eaf3d2222b6da2eb5d1086.tar.xz linux-dev-9558df3a8251f1c636eaf3d2222b6da2eb5d1086.zip | |
net: fec: Issue error for missing but expected PHY
If the PHY is missing but expected, e.g. because of a typ0 in the dt
file, it is not possible to open the interface. ip link returns:
RTNETLINK answers: No such device
It is not very obvious what the problem is. Add a netdev_err() in this
case to make it easier to debug the issue.
[ 21.409385] fec 2188000.ethernet eth0: Unable to connect to phy
RTNETLINK answers: No such device
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/fec_main.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_main.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index a6e323f15637..faa36f6ddf29 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1904,8 +1904,10 @@ static int fec_enet_mii_probe(struct net_device *ndev) phy_dev = of_phy_connect(ndev, fep->phy_node, &fec_enet_adjust_link, 0, fep->phy_interface); - if (!phy_dev) + if (!phy_dev) { + netdev_err(ndev, "Unable to connect to phy\n"); return -ENODEV; + } } else { /* check for attached phy */ for (phy_id = 0; (phy_id < PHY_MAX_ADDR); phy_id++) { |