aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/freescale/fman/fman_port.c
diff options
context:
space:
mode:
authorMadalin Bucur <madalin.bucur@freescale.com>2016-03-22 10:27:16 +0200
committerMadalin Bucur <madalin.bucur@nxp.com>2016-10-04 09:26:06 +0300
commit5df6f7fa47e0306bdbb94ac7f3545697ff92d7d2 (patch)
treee05f6ad79be82c8c1fd07e2d3c88f05db9e58d6f /drivers/net/ethernet/freescale/fman/fman_port.c
parentfsl/fman: fix loadable module compilation (diff)
downloadlinux-dev-5df6f7fa47e0306bdbb94ac7f3545697ff92d7d2.tar.xz
linux-dev-5df6f7fa47e0306bdbb94ac7f3545697ff92d7d2.zip
fsl/fman: small fixes
Make module params static, proper NULL checks, remove __iomem label when misused. Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
Diffstat (limited to 'drivers/net/ethernet/freescale/fman/fman_port.c')
-rw-r--r--drivers/net/ethernet/freescale/fman/fman_port.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c
index 6de808e2593a..8b043e7b070b 100644
--- a/drivers/net/ethernet/freescale/fman/fman_port.c
+++ b/drivers/net/ethernet/freescale/fman/fman_port.c
@@ -1477,7 +1477,8 @@ EXPORT_SYMBOL(fman_port_cfg_buf_prefix_content);
*/
int fman_port_disable(struct fman_port *port)
{
- u32 __iomem *bmi_cfg_reg, *bmi_status_reg, tmp;
+ u32 __iomem *bmi_cfg_reg, *bmi_status_reg;
+ u32 tmp;
bool rx_port, failure = false;
int count;
@@ -1553,7 +1554,8 @@ EXPORT_SYMBOL(fman_port_disable);
*/
int fman_port_enable(struct fman_port *port)
{
- u32 __iomem *bmi_cfg_reg, tmp;
+ u32 __iomem *bmi_cfg_reg;
+ u32 tmp;
bool rx_port;
if (!is_init_done(port->cfg))
@@ -1743,7 +1745,7 @@ static int fman_port_probe(struct platform_device *of_dev)
port->dts_params.base_addr = devm_ioremap(port->dev, res.start,
resource_size(&res));
- if (port->dts_params.base_addr == 0)
+ if (!port->dts_params.base_addr)
dev_err(port->dev, "%s: devm_ioremap() failed\n", __func__);
dev_set_drvdata(&of_dev->dev, port);