diff options
| author |   Madalin Bucur <madalin.bucur@nxp.com> | 2017-10-16 21:36:05 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-18 13:44:46 +0100 |
| commit | 48167c9ce0b91c068430345bf039c7be23fa2f3f (patch) | |
| tree | 79f923832467eafcb2a0dd52a9ad40e20dfb311d /drivers/net/ethernet/freescale/fman | |
| parent | tools: bpftool: use more common tag format (diff) | |
| download | linux-dev-48167c9ce0b91c068430345bf039c7be23fa2f3f.tar.xz linux-dev-48167c9ce0b91c068430345bf039c7be23fa2f3f.zip | |
fsl/fman: remove of_node
The FMan MAC driver allocates a platform device for the Ethernet
driver to probe on. Setting pdev->dev.of_node with the MAC node
triggers the MAC driver probing of the new platform device. While
this fails quickly and does not affect the functionality of the
drivers, it is incorrect and must be removed. This was added to
address a report that DSA code using of_find_net_device_by_node()
is unable to use the DPAA interfaces. Error message seen before
this fix:
fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed
fsl_mac: probe of dpaa-ethernet.0 failed with error -16
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/fman')
| -rw-r--r-- | drivers/net/ethernet/freescale/fman/mac.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 387eb4a88b72..9a265f862065 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -623,7 +623,6 @@ static struct platform_device *dpaa_eth_add_device(int fman_id, goto no_mem; } - pdev->dev.of_node = node; pdev->dev.parent = priv->dev; set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); |