diff options
| author |   Peter Wu <peter@lekensteyn.nl> | 2015-12-08 12:17:42 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-12-08 22:48:01 -0500 |
| commit | 90186af404ada5a47b875bf3c16d0b02bb023ea0 (patch) | |
| tree | 0f08ac63447211f81449237e0b9ffe78996045a8 /drivers/net/ethernet/freescale/fsl_pq_mdio.c | |
| parent | net: thunderx: Correctly distinguish between VF and LMAC count (diff) | |
| download | linux-dev-90186af404ada5a47b875bf3c16d0b02bb023ea0.tar.xz linux-dev-90186af404ada5a47b875bf3c16d0b02bb023ea0.zip | |
r8152: fix lockup when runtime PM is enabled
When an interface is brought up which was previously suspended (via
runtime PM), it would hang. This happens because napi_disable is called
before napi_enable.
Solve this by avoiding napi_enable in the resume during open function
(netif_running is true when open is called, IFF_UP is set after a
successful open; netif_running is false when close is called, but IFF_UP
is then still set).
While at it, remove WORK_ENABLE check from rtl8152_open (introduced with
the original change) because it cannot happen:
- After this patch, runtime resume will not set it during rtl8152_open.
- When link is up, rtl8152_open is not called.
- When link is down during system/auto suspend/resume, it is not set.
Fixes: 41cec84cf285 ("r8152: don't enable napi before rx ready")
Link: https://lkml.kernel.org/r/20151205105912.GA1766@al
Signed-off-by: Peter Wu <peter@lekensteyn.nl>
Acked-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/fsl_pq_mdio.c')
0 files changed, 0 insertions, 0 deletions