diff options
| author |   Mark Brown <broonie@kernel.org> | 2015-11-26 11:59:46 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-11-30 15:19:44 -0500 |
| commit | 0f2c0d32e6536ad39c3e9589d42c53d0ee3bfa08 (patch) | |
| tree | d6bd49c6155f5b1ad26ab3412fc94b0d15daa4ec /drivers/net/ethernet/freescale | |
| parent | net: fsl: Don't use NO_IRQ to check return value of irq_of_parse_and_map() (diff) | |
| download | linux-dev-0f2c0d32e6536ad39c3e9589d42c53d0ee3bfa08.tar.xz linux-dev-0f2c0d32e6536ad39c3e9589d42c53d0ee3bfa08.zip | |
net: fsl: Fix error checking for platform_get_irq()
The gianfar driver has recently been enabled on arm64 but fails to build
since it check the return value of platform_get_irq() against NO_IRQ. Fix
this by instead checking for a negative error code.
Even on ARM where this code was previously being built this check was
incorrect since platform_get_irq() returns a negative error code which
may not be exactly the (unsigned int)(-1) that NO_IRQ is defined to be.
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale')
| -rw-r--r-- | drivers/net/ethernet/freescale/gianfar_ptp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/gianfar_ptp.c b/drivers/net/ethernet/freescale/gianfar_ptp.c index 664d0c261269..b40fba929d65 100644 --- a/drivers/net/ethernet/freescale/gianfar_ptp.c +++ b/drivers/net/ethernet/freescale/gianfar_ptp.c @@ -467,7 +467,7 @@ static int gianfar_ptp_probe(struct platform_device *dev) etsects->irq = platform_get_irq(dev, 0); - if (etsects->irq == NO_IRQ) { + if (etsects->irq < 0) { pr_err("irq not in device tree\n"); goto no_node; } |