diff options
| author |   Huazhong Tan <tanhuazhong@huawei.com> | 2018-01-18 10:37:34 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-01-22 15:36:44 -0500 |
| commit | 5e89cfac2e1e74df075047ca5162a4df1aa11f63 (patch) | |
| tree | 4a5ed21f57d0caa836ba5e144c6dd851cbfca2d3 /drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | |
| parent | net: fec: add necessary defines to work on ARM64 (diff) | |
| download | linux-dev-5e89cfac2e1e74df075047ca5162a4df1aa11f63.tar.xz linux-dev-5e89cfac2e1e74df075047ca5162a4df1aa11f63.zip | |
net: hns: Fix for variable may be used uninitialized warnings
When !CONFIG_REGMAP hns throws compiler warnings since
dsaf_read_syscon ignores the return result from regmap_read,
which allows val to be uninitialized.
Fixes: 86897c960b49 ("net: hns: add syscon operation for dsaf")
Reported-by: Jason Gunthorpe <jgg@ziepe.ca>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h index 46a52d9bb196..886cbbf25761 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h @@ -1034,12 +1034,9 @@ static inline void dsaf_write_syscon(struct regmap *base, u32 reg, u32 value) regmap_write(base, reg, value); } -static inline u32 dsaf_read_syscon(struct regmap *base, u32 reg) +static inline int dsaf_read_syscon(struct regmap *base, u32 reg, u32 *val) { - unsigned int val; - - regmap_read(base, reg, &val); - return val; + return regmap_read(base, reg, val); } #define dsaf_read_dev(a, reg) \ |