diff options
| author |   Gustavo A. R. Silva <gustavoars@kernel.org> | 2021-02-10 13:28:41 -0600 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-02-11 14:22:13 -0800 |
| commit | 205238f4ed3e14aed07a7b0121b94e404e65e78c (patch) | |
| tree | 836b4b192ed5b65365b239c74739dc2f38418c0b /drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | |
| parent | net: stmmac: dwmac-intel-plat: remove unnecessary initialization (diff) | |
| download | linux-dev-205238f4ed3e14aed07a7b0121b94e404e65e78c.tar.xz linux-dev-205238f4ed3e14aed07a7b0121b94e404e65e78c.zip | |
net: hns3: fix return of random stack value
Currently, a random stack value is being returned because variable
_ret_ is not properly initialized. This variable is actually not
used anymore and it should be removed.
Fix this by removing all instances of variable ret and return 0.
Fixes: 64749c9c38a9 ("net: hns3: remove redundant return value of hns3_uninit_all_ring()")
Addresses-Coverity-ID: 1501700 ("Uninitialized scalar variable")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns3/hns3_enet.c')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 9565b7999426..bf4302a5cf95 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -4640,7 +4640,6 @@ static int hns3_reset_notify_uninit_enet(struct hnae3_handle *handle) { struct net_device *netdev = handle->kinfo.netdev; struct hns3_nic_priv *priv = netdev_priv(netdev); - int ret; if (!test_and_clear_bit(HNS3_NIC_STATE_INITED, &priv->state)) { netdev_warn(netdev, "already uninitialized\n"); @@ -4662,7 +4661,7 @@ static int hns3_reset_notify_uninit_enet(struct hnae3_handle *handle) hns3_put_ring_config(priv); - return ret; + return 0; } static int hns3_reset_notify(struct hnae3_handle *handle, |