diff options
| author |   Guojia Liao <liaoguojia@huawei.com> | 2019-08-16 16:09:39 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-18 12:59:12 -0700 |
| commit | 37417c6625cae97762d7095863b0cf5a127f1c4e (patch) | |
| tree | 9b489704686f7b488d9261ccb21ba696ef664263 /drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | |
| parent | net: hns3: modify redundant initialization of variable (diff) | |
| download | linux-dev-37417c6625cae97762d7095863b0cf5a127f1c4e.tar.xz linux-dev-37417c6625cae97762d7095863b0cf5a127f1c4e.zip | |
net: hns3: fix error and incorrect format
The pointer type parameter should be declare as const for preventing
from its pointed value being unexpected modified.
The uninitialized variable can not be return directly. The default
return value is 0 if no abnormal result.
This patch fixes the preceding two errors, deletes redundant
declaration of a function and align one parameter.
Signed-off-by: Guojia Liao <liaoguojia@huawei.com>
Signed-off-by: Weihang Li <liweihang@hisilicon.com>
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c index 42606538bb01..0332d6fb4c0d 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c @@ -704,7 +704,7 @@ static int hns3_get_link_ksettings(struct net_device *netdev, return 0; } -static int hns3_check_ksettings_param(struct net_device *netdev, +static int hns3_check_ksettings_param(const struct net_device *netdev, const struct ethtool_link_ksettings *cmd) { struct hnae3_handle *handle = hns3_get_handle(netdev); |