diff options
| author |   Huazhong Tan <tanhuazhong@huawei.com> | 2018-05-01 19:56:01 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-05-01 15:08:37 -0400 |
| commit | c5ef83cbb1e9fa17a3b78fb2deb25ae8beebbf48 (patch) | |
| tree | 9bacfda20143e4fa5b2fbe45373d631ddb429494 /drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | |
| parent | net: hns3: Fixes the error legs in hclge_init_ae_dev function (diff) | |
| download | linux-dev-c5ef83cbb1e9fa17a3b78fb2deb25ae8beebbf48.tar.xz linux-dev-c5ef83cbb1e9fa17a3b78fb2deb25ae8beebbf48.zip | |
net: hns3: fix for phy_addr error in hclge_mac_mdio_config
When phy exists, phy_addr must less than PHY_MAX_ADDR.
If not, hclge_mac_mdio_config should return error.
And for fiber(phy_addr=0xff), it does not need hclge_mac_mdio_config.
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c index 682c2d6618e7..9f7932e423b5 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c @@ -140,8 +140,11 @@ int hclge_mac_mdio_config(struct hclge_dev *hdev) struct mii_bus *mdio_bus; int ret; - if (hdev->hw.mac.phy_addr >= PHY_MAX_ADDR) - return 0; + if (hdev->hw.mac.phy_addr >= PHY_MAX_ADDR) { + dev_err(&hdev->pdev->dev, "phy_addr(%d) is too large.\n", + hdev->hw.mac.phy_addr); + return -EINVAL; + } mdio_bus = devm_mdiobus_alloc(&hdev->pdev->dev); if (!mdio_bus) |