diff options
| author |   Jia-Ju Bai <baijiaju1990@gmail.com> | 2021-03-07 00:40:12 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-03-08 11:56:00 -0800 |
| commit | 143c253f42bad20357e7e4432087aca747c43384 (patch) | |
| tree | c5d1b1378faf9c95ea82255007788b057f812e7a /drivers/net/ethernet/hisilicon/hns | |
| parent | net: usb: log errors to dmesg/syslog (diff) | |
| download | linux-dev-143c253f42bad20357e7e4432087aca747c43384.tar.xz linux-dev-143c253f42bad20357e7e4432087aca747c43384.zip | |
net: hisilicon: hns: fix error return code of hns_nic_clear_all_rx_fetch()
When hns_assemble_skb() returns NULL to skb, no error return code of
hns_nic_clear_all_rx_fetch() is assigned.
To fix this bug, ret is assigned with -ENOMEM in this case.
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index 5d7824d2b4d4..c66a7a51198e 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c @@ -1663,8 +1663,10 @@ static int hns_nic_clear_all_rx_fetch(struct net_device *ndev) for (j = 0; j < fetch_num; j++) { /* alloc one skb and init */ skb = hns_assemble_skb(ndev); - if (!skb) + if (!skb) { + ret = -ENOMEM; goto out; + } rd = &tx_ring_data(priv, skb->queue_mapping); hns_nic_net_xmit_hw(ndev, skb, rd); |