aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/hisilicon/hns
diff options
context:
space:
mode:
authorYunjian Wang <wangyunjian@huawei.com>2020-12-26 16:10:05 +0800
committerDavid S. Miller <davem@davemloft.net>2020-12-28 14:57:35 -0800
commit5ede3ada3da7f050519112b81badc058190b9f9f (patch)
treeedf049211280af9e8fb3b40edbad9e0ef1de46f3 /drivers/net/ethernet/hisilicon/hns
parentnet: sched: prevent invalid Scell_log shift count (diff)
downloadlinux-dev-5ede3ada3da7f050519112b81badc058190b9f9f.tar.xz
linux-dev-5ede3ada3da7f050519112b81badc058190b9f9f.zip
net: hns: fix return value check in __lb_other_process()
The function skb_copy() could return NULL, the return value need to be checked. Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support") Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns')
-rw-r--r--drivers/net/ethernet/hisilicon/hns/hns_ethtool.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
index 7165da0ee9aa..a6e3f07caf99 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
@@ -415,6 +415,10 @@ static void __lb_other_process(struct hns_nic_ring_data *ring_data,
/* for mutl buffer*/
new_skb = skb_copy(skb, GFP_ATOMIC);
dev_kfree_skb_any(skb);
+ if (!new_skb) {
+ netdev_err(ndev, "skb alloc failed\n");
+ return;
+ }
skb = new_skb;
check_ok = 0;