diff options
| author |   Kejian Yan <yankejian@huawei.com> | 2017-04-01 12:03:44 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-04-03 14:48:43 -0700 |
| commit | d592a4a4b9f2727efd8d7718bb5c9ae0d03614bd (patch) | |
| tree | 7445227f5cfbbe82cadf437f201efb73043e645e /drivers/net/ethernet/hisilicon/hns_mdio.c | |
| parent | net: hns: Clean redundant code from hns_mdio.c file (diff) | |
| download | linux-dev-d592a4a4b9f2727efd8d7718bb5c9ae0d03614bd.tar.xz linux-dev-d592a4a4b9f2727efd8d7718bb5c9ae0d03614bd.zip | |
net: hns: Optimise the code in hns_mdio_wait_ready()
This patch fixes the code to clear pclint warning/info.
Reported-by: Ping Zhang <zhangping5@huawei.com>
Signed-off-by: Kejian Yan <yankejian@huawei.com>
Reviewed-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns_mdio.c')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns_mdio.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index fad1c5b1b991..e5221d95afe1 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -175,18 +175,20 @@ static int mdio_sc_cfg_reg_write(struct hns_mdio_device *mdio_dev, static int hns_mdio_wait_ready(struct mii_bus *bus) { struct hns_mdio_device *mdio_dev = bus->priv; + u32 cmd_reg_value; int i; - u32 cmd_reg_value = 1; /* waitting for MDIO_COMMAND_REG 's mdio_start==0 */ /* after that can do read or write*/ - for (i = 0; cmd_reg_value; i++) { + for (i = 0; i < MDIO_TIMEOUT; i++) { cmd_reg_value = MDIO_GET_REG_BIT(mdio_dev, MDIO_COMMAND_REG, MDIO_CMD_START_B); - if (i == MDIO_TIMEOUT) - return -ETIMEDOUT; + if (!cmd_reg_value) + break; } + if ((i == MDIO_TIMEOUT) && cmd_reg_value) + return -ETIMEDOUT; return 0; } |