diff options
| author |   Sukadev Bhattiprolu <sukadev@linux.ibm.com> | 2022-01-21 18:59:20 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-01-24 12:05:03 +0000 |
| commit | 48079e7fdd0269d66b1d7d66ae88bd03162464ad (patch) | |
| tree | 726ccdf02ce36ad1a629844187a2f213d6fb46dd /drivers/net/ethernet/ibm | |
| parent | ibmvnic: init ->running_cap_crqs early (diff) | |
| download | linux-dev-48079e7fdd0269d66b1d7d66ae88bd03162464ad.tar.xz linux-dev-48079e7fdd0269d66b1d7d66ae88bd03162464ad.zip | |
ibmvnic: don't spin in tasklet
ibmvnic_tasklet() continuously spins waiting for responses to all
capability requests. It does this to avoid encountering an error
during initialization of the vnic. However if there is a bug in the
VIOS and we do not receive a response to one or more queries the
tasklet ends up spinning continuously leading to hard lock ups.
If we fail to receive a message from the VIOS it is reasonable to
timeout the login attempt rather than spin indefinitely in the tasklet.
Fixes: 249168ad07cd ("ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs")
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Reviewed-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ibm')
| -rw-r--r-- | drivers/net/ethernet/ibm/ibmvnic.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index c65e98bc4f7d..3df7fd0b944e 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -5499,12 +5499,6 @@ static void ibmvnic_tasklet(struct tasklet_struct *t) ibmvnic_handle_crq(crq, adapter); crq->generic.first = 0; } - - /* remain in tasklet until all - * capabilities responses are received - */ - if (!adapter->wait_capability) - done = true; } /* if capabilities CRQ's were sent in this tasklet, the following * tasklet must wait until all responses are received |