diff options
| author |   Eric Dumazet <edumazet@google.com> | 2018-09-21 15:27:42 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-23 21:55:24 -0700 |
| commit | dda9d57e2d4245c0d8e309ee7399bf2ebfca64ae (patch) | |
| tree | 7cd28c9349e1755f1ed2ff22496d94b2806691dc /drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | |
| parent | ixgbevf: remove ndo_poll_controller (diff) | |
| download | linux-dev-dda9d57e2d4245c0d8e309ee7399bf2ebfca64ae.tar.xz linux-dev-dda9d57e2d4245c0d8e309ee7399bf2ebfca64ae.zip | |
fm10k: remove ndo_poll_controller
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
lasts for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.
fm10k uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/fm10k/fm10k_netdev.c')
| -rw-r--r-- | drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c index 929f538d28bc..538a8467f434 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c @@ -1648,9 +1648,6 @@ static const struct net_device_ops fm10k_netdev_ops = { .ndo_udp_tunnel_del = fm10k_udp_tunnel_del, .ndo_dfwd_add_station = fm10k_dfwd_add_station, .ndo_dfwd_del_station = fm10k_dfwd_del_station, -#ifdef CONFIG_NET_POLL_CONTROLLER - .ndo_poll_controller = fm10k_netpoll, -#endif .ndo_features_check = fm10k_features_check, }; |