diff options
| author |   Shannon Nelson <shannon.nelson@intel.com> | 2015-08-26 15:14:11 -0400 |
|---|---|---|
| committer |   Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2015-10-07 13:38:11 -0700 |
| commit | df08fd4dbcc95cbc5a35745b6a77a9df0dc5776f (patch) | |
| tree | 2a3147419146e937e89ff9797e3d1c36eae63444 /drivers/net/ethernet/intel/i40evf/i40e_adminq.h | |
| parent | i40e/i40evf: add driver support for new device ids (diff) | |
| download | linux-dev-df08fd4dbcc95cbc5a35745b6a77a9df0dc5776f.tar.xz linux-dev-df08fd4dbcc95cbc5a35745b6a77a9df0dc5776f.zip | |
i40e/i40evf: fix a potential type compare issue
Rework an if expression to assure there is no type compare problem between
a size and a possible negative number.
Change-ID: I4921fcc96abfcf69490efce020a9e4007f251c99
Reported-by: Helin Zhang <helin.zhang@intel.com>
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40evf/i40e_adminq.h')
| -rw-r--r-- | drivers/net/ethernet/intel/i40evf/i40e_adminq.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_adminq.h b/drivers/net/ethernet/intel/i40evf/i40e_adminq.h index e62e951cf208..a3eae5d9a2bd 100644 --- a/drivers/net/ethernet/intel/i40evf/i40e_adminq.h +++ b/drivers/net/ethernet/intel/i40evf/i40e_adminq.h @@ -144,8 +144,7 @@ static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc) if (aq_ret == I40E_ERR_ADMIN_QUEUE_TIMEOUT) return -EAGAIN; - if (aq_rc >= (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])) || - aq_rc < 0) + if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])))) return -ERANGE; return aq_to_posix[aq_rc]; |