aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/i40evf
diff options
context:
space:
mode:
authorMitch Williams <mitch.a.williams@intel.com>2014-03-06 08:59:52 +0000
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2014-03-21 01:31:47 -0700
commitc89a9e00f90cea4d824ff5890c86332a6687f830 (patch)
tree3b5ae7ac69440e1f79c231ae83b47031a93ec2ff /drivers/net/ethernet/intel/i40evf
parenti40e: Fix a message string (diff)
downloadlinux-dev-c89a9e00f90cea4d824ff5890c86332a6687f830.tar.xz
linux-dev-c89a9e00f90cea4d824ff5890c86332a6687f830.zip
i40evf: don't shut down admin queue on error
If the driver encounters an error while communicating with the PF driver, don't just shut down the admin queue unconditionally. The PF may be delayed, and shutting down the admin queue causes it to fail completely. If this happens, the VF will never complete initialization. Change-ID: I6192e9d8caeefb738428c3597fa2f54fa400ce7f Signed-off-by: Mitch Williams <mitch.a.williams@intel.com> Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com> Tested-by: Sibai Li <sibai.li@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40evf')
-rw-r--r--drivers/net/ethernet/intel/i40evf/i40evf_main.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index d381bcc4ea9f..4d547abc59dc 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -2133,8 +2133,6 @@ err_alloc:
kfree(adapter->vf_res);
adapter->vf_res = NULL;
err:
- if (hw->aq.asq.count)
- i40evf_shutdown_adminq(hw); /* ignore error */
/* Things went into the weeds, so try again later */
if (++adapter->aq_wait_count > I40EVF_AQ_MAX_ERR) {
dev_err(&pdev->dev, "Failed to communicate with PF; giving up.\n");