diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-19 15:51:09 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-19 20:10:28 +0100 |
commit | 293f8995948330e1df9228519535593618b5ec0e (patch) | |
tree | df492ecb19115326d288a49bc06fc89ff7370d63 /drivers/net/ethernet/intel/igb/igb_ethtool.c | |
parent | serial_core: Remove SUPPORT_SYSRQ ifdeffery (diff) | |
download | linux-dev-293f8995948330e1df9228519535593618b5ec0e.tar.xz linux-dev-293f8995948330e1df9228519535593618b5ec0e.zip |
tty: serial: 21285: stop using the unused[] variable from struct uart_port
Much like the samsung_tty driver (now I know where they copied the idea
from), the 21285 uart driver uses 2 bytes from the "unused" array of
struct uart_port to keep tx/rx enabled/disabled state. Those fields are
going away (they were never really needed in the first place), so fix up
the 21285 driver by another horrible hack.
Instead of creating a whole structure for just 2 bytes, just use two
bits from the private_data pointer instead, as that pointer is never
used. The two bits reflect if tx/rx is now enabled/disabled.
Astute readers will note that once rx is disabled, nothing ever seems to
turn it back on, making one wonder if anyone has ever done this.
Reported-by: kbuild test robot <lkp@intel.com>
Cc: Dmitry Safonov <dima@arista.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/r/20191219145109.GA1962496@kroah.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/ethernet/intel/igb/igb_ethtool.c')
0 files changed, 0 insertions, 0 deletions