aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/igc/igc.h
diff options
context:
space:
mode:
authorAndre Guedes <andre.guedes@intel.com>2020-05-12 10:35:52 -0700
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2020-05-28 20:13:11 -0700
commit3d3e9b6b6a878d01c04629eae8787de132056533 (patch)
tree44b1a27522cef8ff2c5901c8aa0c480e65e53775 /drivers/net/ethernet/intel/igc/igc.h
parentigc: Remove unused flags (diff)
downloadlinux-dev-3d3e9b6b6a878d01c04629eae8787de132056533.tar.xz
linux-dev-3d3e9b6b6a878d01c04629eae8787de132056533.zip
igc: Reject NFC rules with multiple matches
The way Rx queue assignment based on mac address, Ethertype and VLAN priority filtering operates in I225 doesn't allow us to properly support NFC rules with multiple matches. Consider the following example which assigns to queue 2 frames matching the address MACADDR *and* Ethertype ETYPE. $ ethtool -N eth0 flow-type ether dst <MACADDR> proto <ETYPE> queue 2 When such rule is applied, we have 2 unwanted behaviors: 1) Any frame matching MACADDR will be assigned to queue 2. It doesn't matter the ETYPE value. 2) Any accepted frame that has Ethertype equals to ETYPE, no matter the mac address, will be assigned to queue 2 as well. In current code, multiple-match filters are accepted by the driver, even though it doesn't support them properly. This patch adds a check for multiple-match rules in igc_ethtool_is_nfc_rule_valid() so they are rejected. Signed-off-by: Andre Guedes <andre.guedes@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc.h')
0 files changed, 0 insertions, 0 deletions