diff options
| author |   Xin Long <lucien.xin@gmail.com> | 2018-11-14 00:48:28 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-11-16 19:44:15 -0800 |
| commit | 761f60261b4401aa368d71d431b4c218af0efcee (patch) | |
| tree | 3963e8f7e325e2c65d311bb70b520d6c823d7841 /drivers/net/ethernet/lantiq_xrx200.c | |
| parent | net: mvneta: Don't advertise 2.5G modes (diff) | |
| download | linux-dev-761f60261b4401aa368d71d431b4c218af0efcee.tar.xz linux-dev-761f60261b4401aa368d71d431b4c218af0efcee.zip | |
ipv6: fix a dst leak when removing its exception
These is no need to hold dst before calling rt6_remove_exception_rt().
The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(),
which has been removed in Commit 93531c674315 ("net/ipv6: separate
handling of FIB entries from dst based routes"). Otherwise, it will
cause a dst leak.
This patch is to simply remove the dst_hold_safe() call before calling
rt6_remove_exception_rt() and also do the same in ip6_del_cached_rt().
It's safe, because the removal of the exception that holds its dst's
refcnt is protected by rt6_exception_lock.
Fixes: 93531c674315 ("net/ipv6: separate handling of FIB entries from dst based routes")
Fixes: 23fb93a4d3f1 ("net/ipv6: Cleanup exception and cache route handling")
Reported-by: Li Shuang <shuali@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/lantiq_xrx200.c')
0 files changed, 0 insertions, 0 deletions