diff options
| author |   Aleksander Jan Bajkowski <olek2@wp.pl> | 2021-06-08 23:21:07 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-08 19:16:32 -0700 |
| commit | f2386cf7c5f4ff5d7b584f5d92014edd7df6c676 (patch) | |
| tree | f9c56ac832d6312aea2dd3c9750760b1bf73dcad /drivers/net/ethernet/lantiq_xrx200.c | |
| parent | net: ena: fix DMA mapping function issues in XDP (diff) | |
| download | linux-dev-f2386cf7c5f4ff5d7b584f5d92014edd7df6c676.tar.xz linux-dev-f2386cf7c5f4ff5d7b584f5d92014edd7df6c676.zip | |
net: lantiq: disable interrupt before sheduling NAPI
This patch fixes TX hangs with threaded NAPI enabled. The scheduled
NAPI seems to be executed in parallel with the interrupt on second
thread. Sometimes it happens that ltq_dma_disable_irq() is executed
after xrx200_tx_housekeeping(). The symptom is that TX interrupts
are disabled in the DMA controller. As a result, the TX hangs after
a few seconds of the iperf test. Scheduling NAPI after disabling
interrupts fixes this issue.
Tested on Lantiq xRX200 (BT Home Hub 5A).
Fixes: 9423361da523 ("net: lantiq: Disable IRQs only if NAPI gets scheduled ")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/lantiq_xrx200.c')
| -rw-r--r-- | drivers/net/ethernet/lantiq_xrx200.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c index 36dc3e5f6218..0e10d8aeffe1 100644 --- a/drivers/net/ethernet/lantiq_xrx200.c +++ b/drivers/net/ethernet/lantiq_xrx200.c @@ -352,8 +352,8 @@ static irqreturn_t xrx200_dma_irq(int irq, void *ptr) struct xrx200_chan *ch = ptr; if (napi_schedule_prep(&ch->napi)) { - __napi_schedule(&ch->napi); ltq_dma_disable_irq(&ch->dma); + __napi_schedule(&ch->napi); } ltq_dma_ack_irq(&ch->dma); |