diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2013-11-13 10:52:47 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-11-14 03:11:36 -0500 |
| commit | 6115c11fe1a5a636ac99fc823b00df4ff3c0674e (patch) | |
| tree | 95af867499c2ac0afda52bda61d19a572bf10fd5 /drivers/net/ethernet/marvell/mv643xx_eth.c | |
| parent | net: cdc_ncm: cleanup a type issue in cdc_ncm_setup() (diff) | |
| download | linux-dev-6115c11fe1a5a636ac99fc823b00df4ff3c0674e.tar.xz linux-dev-6115c11fe1a5a636ac99fc823b00df4ff3c0674e.zip | |
net: mv643xx_eth: potential NULL dereference in probe()
We assume that "mp->phy" can be NULL a couple lines before the
dereference.
Fixes: 1cce16d37d0f ('net: mv643xx_eth: Add missing phy_addr_set in DT mode')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Acked-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell/mv643xx_eth.c')
| -rw-r--r-- | drivers/net/ethernet/marvell/mv643xx_eth.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 00cd36e08601..61088a6a9424 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -2890,7 +2890,8 @@ static int mv643xx_eth_probe(struct platform_device *pdev) PHY_INTERFACE_MODE_GMII); if (!mp->phy) err = -ENODEV; - phy_addr_set(mp, mp->phy->addr); + else + phy_addr_set(mp, mp->phy->addr); } else if (pd->phy_addr != MV643XX_ETH_PHY_NONE) { mp->phy = phy_scan(mp, pd->phy_addr); |