diff options
| author |   Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-12-20 16:29:30 +0800 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2020-12-22 18:49:45 -0800 |
| commit | 58f60329a6be35a5653edb3fd2023ccef9eb9943 (patch) | |
| tree | fe4a589341890581a659f6bfe22de837210f9adb /drivers/net/ethernet/marvell/mvneta.c | |
| parent | ibmvnic: fix login buffer memory leak (diff) | |
| download | linux-dev-58f60329a6be35a5653edb3fd2023ccef9eb9943.tar.xz linux-dev-58f60329a6be35a5653edb3fd2023ccef9eb9943.zip | |
net: ethernet: mvneta: Fix error handling in mvneta_probe
When mvneta_port_power_up() fails, we should execute
cleanup functions after label err_netdev to avoid memleak.
Fixes: 41c2b6b4f0f80 ("net: ethernet: mvneta: Add back interface mode validation")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20201220082930.21623-1-dinghao.liu@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/marvell/mvneta.c')
| -rw-r--r-- | drivers/net/ethernet/marvell/mvneta.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 563ceac3060f..3369ec717a51 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -5255,7 +5255,7 @@ static int mvneta_probe(struct platform_device *pdev) err = mvneta_port_power_up(pp, pp->phy_interface); if (err < 0) { dev_err(&pdev->dev, "can't power up port\n"); - return err; + goto err_netdev; } /* Armada3700 network controller does not support per-cpu |