diff options
| author |   Fuqian Huang <huangfq.daxian@gmail.com> | 2019-07-15 11:19:11 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-07-15 11:06:27 -0700 |
| commit | 3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9 (patch) | |
| tree | bc48ce9996493d2db1151e6d200037db8076a69f /drivers/net/ethernet/marvell/skge.c | |
| parent | atm: idt77252: Remove call to memset after dma_alloc_coherent (diff) | |
| download | linux-dev-3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9.tar.xz linux-dev-3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9.zip | |
ethernet: remove redundant memset
kvzalloc already zeroes the memory during the allocation.
pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So the memset after these function is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell/skge.c')
| -rw-r--r-- | drivers/net/ethernet/marvell/skge.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 35a92fd2cf39..9ac854c2b371 100644 --- a/drivers/net/ethernet/marvell/skge.c +++ b/drivers/net/ethernet/marvell/skge.c @@ -2558,8 +2558,6 @@ static int skge_up(struct net_device *dev) goto free_pci_mem; } - memset(skge->mem, 0, skge->mem_size); - err = skge_ring_alloc(&skge->rx_ring, skge->mem, skge->dma); if (err) goto free_pci_mem; |