diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-10-08 16:26:50 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-10-09 19:59:45 +0100 |
| commit | 897fab7a726aa461ad0dcda7c345d5261bb6a0ca (patch) | |
| tree | c631a89a6a781330a2a84c3676a4818a7c45a160 /drivers/net/ethernet/marvell | |
| parent | macvlan: enforce a consistent minimal mtu (diff) | |
| download | linux-dev-897fab7a726aa461ad0dcda7c345d5261bb6a0ca.tar.xz linux-dev-897fab7a726aa461ad0dcda7c345d5261bb6a0ca.zip | |
octeontx2-pf: mcs: fix missing unlock in some error paths
Add the missing unlock in some error paths.
Fixes: c54ffc73601c ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell')
| -rw-r--r-- | drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c index 18420d9a145f..9809f551fc2e 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c @@ -284,7 +284,7 @@ static int cn10k_mcs_write_sc_cam(struct otx2_nic *pfvf, sc_req = otx2_mbox_alloc_msg_mcs_rx_sc_cam_write(mbox); if (!sc_req) { - return -ENOMEM; + ret = -ENOMEM; goto fail; } @@ -594,7 +594,7 @@ static int cn10k_mcs_ena_dis_flowid(struct otx2_nic *pfvf, u16 hw_flow_id, req = otx2_mbox_alloc_msg_mcs_flowid_ena_entry(mbox); if (!req) { - return -ENOMEM; + ret = -ENOMEM; goto fail; } @@ -1653,6 +1653,7 @@ int cn10k_mcs_init(struct otx2_nic *pfvf) return 0; fail: dev_err(pfvf->dev, "Cannot notify PN wrapped event\n"); + mutex_unlock(&mbox->lock); return 0; } |