diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2016-03-14 15:07:12 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-03-14 13:06:27 -0400 |
| commit | 916848ca6f10e1bbf0c2af72ef51e494aaa5c466 (patch) | |
| tree | ff175c0cf4225ef4072f964093b1cc94239ea874 /drivers/net/ethernet/mediatek | |
| parent | net: mediatek: remove incorrect dma_mask assignment (diff) | |
| download | linux-dev-916848ca6f10e1bbf0c2af72ef51e494aaa5c466.tar.xz linux-dev-916848ca6f10e1bbf0c2af72ef51e494aaa5c466.zip | |
net: mediatek: check device_reset return code
The device_reset() function may fail, so we have to check
its return value, e.g. to make deferred probing work correctly.
gcc warns about it because of the warn_unused_result attribute:
drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_probe':
drivers/net/ethernet/mediatek/mtk_eth_soc.c:1679:2: error: ignoring return value of 'device_reset', declared with attribute warn_unused_result [-Werror=unused-result]
This adds the trivial error check to propagate the return value
to the generic platform device probe code.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mediatek')
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 87f417712da0..1e6c5498bba9 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1676,7 +1676,9 @@ static int mtk_probe(struct platform_device *pdev) struct mtk_eth *eth; int err; - device_reset(&pdev->dev); + err = device_reset(&pdev->dev); + if (err) + return err; match = of_match_device(of_mtk_match, &pdev->dev); soc = (struct mtk_soc_data *)match->data; |