diff options
| author |   Yishai Hadas <yishaih@mellanox.com> | 2019-06-30 19:23:22 +0300 |
|---|---|---|
| committer |   Leon Romanovsky <leonro@mellanox.com> | 2019-07-03 20:54:57 +0300 |
| commit | 1d49ce1e05f804d9238eda66d6010eb492668a37 (patch) | |
| tree | 37c596d73a991d32c9d124633ab5920052b357f4 /drivers/net/ethernet/mellanox/mlx5/core/cq.c | |
| parent | net/mlx5: E-Switch, Handle UC address change in switchdev mode (diff) | |
| download | linux-dev-1d49ce1e05f804d9238eda66d6010eb492668a37.tar.xz linux-dev-1d49ce1e05f804d9238eda66d6010eb492668a37.zip | |
net/mlx5: Fix mlx5_core_destroy_cq() error flow
The firmware command to destroy a CQ might fail when the object is
referenced by other object and the ref count is managed by the firmware.
To enable a second successful destruction post the first failure need to
change mlx5_eq_del_cq() to be a void function.
As an error in mlx5_eq_del_cq() is quite fatal from the option to
recover, a debug message inside it should be good enougth and it was
changed to be void.
Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx5/core/cq.c')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/cq.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cq.c b/drivers/net/ethernet/mellanox/mlx5/core/cq.c index 713a17ee3751..703d88332bc6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/cq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cq.c @@ -158,13 +158,8 @@ int mlx5_core_destroy_cq(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq) u32 in[MLX5_ST_SZ_DW(destroy_cq_in)] = {0}; int err; - err = mlx5_eq_del_cq(mlx5_get_async_eq(dev), cq); - if (err) - return err; - - err = mlx5_eq_del_cq(&cq->eq->core, cq); - if (err) - return err; + mlx5_eq_del_cq(mlx5_get_async_eq(dev), cq); + mlx5_eq_del_cq(&cq->eq->core, cq); MLX5_SET(destroy_cq_in, in, opcode, MLX5_CMD_OP_DESTROY_CQ); MLX5_SET(destroy_cq_in, in, cqn, cq->cqn); |