diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2017-06-06 11:47:40 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-06-06 12:21:29 -0400 |
| commit | 928a759593d21ec184536bde0b4816d21bcd5a86 (patch) | |
| tree | ac87ea20de893af70c0fbc753a20b3e0ab2aa8ca /drivers/net/ethernet/mellanox/mlxfw | |
| parent | Merge tag 'rxrpc-rewrite-20170606' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs (diff) | |
| download | linux-dev-928a759593d21ec184536bde0b4816d21bcd5a86.tar.xz linux-dev-928a759593d21ec184536bde0b4816d21bcd5a86.zip | |
net/mlxfw: remove redundant goto on error check
The check to see of err is set and the subsequent goto is extraneous
as the next statement is where the goto is jumping to. Remove this
redundant check and goto.
Detected by CoverityScan, CID#1437734 ("Identical code for
different branches")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Yotam Gigi <yotamg@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlxfw')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c index 7e9589061d30..628150d28061 100644 --- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c +++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c @@ -492,8 +492,6 @@ static int mlxfw_mfa2_file_cb_offset_xz(const struct mlxfw_mfa2_file *mfa2_file, dec_buf.out_pos = 0; dec_buf.out_size = size; err = mlxfw_mfa2_xz_dec_run(xz_dec, &dec_buf, &finished); - if (err) - goto out; out: xz_dec_end(xz_dec); return err; |