diff options
| author |   Ido Schimmel <idosch@mellanox.com> | 2019-04-10 06:58:15 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-04-10 11:57:08 -0700 |
| commit | 972fae683cbad5cf348268e76abc6d55cfb3ba87 (patch) | |
| tree | da2dbfb16a4f1e3d05183e2bd762fc87df0eed21 /drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | |
| parent | mlxsw: core: Do not use WQ_MEM_RECLAIM for mlxsw workqueue (diff) | |
| download | linux-dev-972fae683cbad5cf348268e76abc6d55cfb3ba87.tar.xz linux-dev-972fae683cbad5cf348268e76abc6d55cfb3ba87.zip | |
mlxsw: spectrum_router: Do not check VRF MAC address
Commit 74bc99397438 ("mlxsw: spectrum_router: Veto unsupported RIF MAC
addresses") enabled the driver to veto router interface (RIF) MAC
addresses that it cannot support.
This check should only be performed for interfaces for which the driver
actually configures a RIF. A VRF upper is not one of them, so ignore it.
Without this patch it is not possible to set an IP address on the VRF
device and use it as a loopback.
Fixes: 74bc99397438 ("mlxsw: spectrum_router: Veto unsupported RIF MAC addresses")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reported-by: Alexander Petrovskiy <alexpe@mellanox.com>
Tested-by: Alexander Petrovskiy <alexpe@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index 52fed8c7bf1e..902e766a8ed3 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -6781,7 +6781,7 @@ static int mlxsw_sp_router_port_check_rif_addr(struct mlxsw_sp *mlxsw_sp, /* A RIF is not created for macvlan netdevs. Their MAC is used to * populate the FDB */ - if (netif_is_macvlan(dev)) + if (netif_is_macvlan(dev) || netif_is_l3_master(dev)) return 0; for (i = 0; i < MLXSW_CORE_RES_GET(mlxsw_sp->core, MAX_RIFS); i++) { |