aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/micrel
diff options
context:
space:
mode:
authorJoachim Eastwood <manabian@gmail.com>2012-11-16 04:47:15 +0000
committerDavid S. Miller <davem@davemloft.net>2012-11-19 19:01:18 -0500
commitc867b55eb4831a493631205f2744b2e77ce0983b (patch)
treec8d603edb45c8b7e97ce765f908efa5d60f4d76d /drivers/net/ethernet/micrel
parentnet: rds: use this_cpu_* per-cpu helper (diff)
downloadlinux-dev-c867b55eb4831a493631205f2744b2e77ce0983b.tar.xz
linux-dev-c867b55eb4831a493631205f2744b2e77ce0983b.zip
net/ethernet: remove useless is_valid_ether_addr from drivers ndo_open
If ndo_validate_addr is set to the generic eth_validate_addr function there is no point in calling is_valid_ether_addr from driver ndo_open if ndo_open is not used elsewhere in the driver. With this change is_valid_ether_addr will be called from the generic eth_validate_addr function. So there should be no change in the actual behavior. Signed-off-by: Joachim Eastwood <manabian@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/micrel')
-rw-r--r--drivers/net/ethernet/micrel/ks8695net.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/micrel/ks8695net.c b/drivers/net/ethernet/micrel/ks8695net.c
index dccae1d1743a..e62c31234cfa 100644
--- a/drivers/net/ethernet/micrel/ks8695net.c
+++ b/drivers/net/ethernet/micrel/ks8695net.c
@@ -1249,9 +1249,6 @@ ks8695_open(struct net_device *ndev)
struct ks8695_priv *ksp = netdev_priv(ndev);
int ret;
- if (!is_valid_ether_addr(ndev->dev_addr))
- return -EADDRNOTAVAIL;
-
ks8695_reset(ksp);
ks8695_update_mac(ksp);